Jason (jblizzle) really covered this well, so I'll just add some links to some other posts and scientific papers, though it's pretty ridiculous for anyone to actually believe what any manufacturer's website says without double checking against real science. There are older threads such as
this one and
this one that have talked about the pros and cons of SWCG pools.
It is incorrect to claim that higher sodium chloride salt levels attack the plaster. It's high sulfate levels that are detrimental to plaster but that has nothing to do with an SWCG. The higher salt level is only an issue for soft stone (i.e. coping) from splash-out and evaporation cycles as described in
this paper and is why the issue is primarily seen in drier climates since in areas with summer rains such salt is diluted by the rain. Also note that non-SWCG pools also have salt so the issue is only a matter of degree. All pools will degrade soft stone and all can be mitigated by use of stone sealant or use of harder (less porous) stone or concrete. I do not have an SWCG but I seal my concrete, not so much for salt splash-out but to limit weathering in general.
As for metal corrosion, the higher salt level does corrode metal faster and in particular higher chloride levels are more detrimental to stainless steel since they interfere with restoration of the passivity layer that prevents corrosion. However, in practice, if higher quality stainless steel is used then this is not an issue. It's usually aluminum or lower quality stainless steel that show problems, but even here one can use a zinc sacrificial anode buried in moist soil and connected to the bonding wire to protect all metal in contact with the water. Here again, such corrosion is always occurring in all pools so is only a matter of degree.
I believe you've seen enough posts for stable pH to know that the strong rise in pH from SWCG systems is not an absolute. If one follows the recommendations for pH, TA, and CYA levels on this forum then one can minimize this effect that is due primarily to the increased aeration causing greater carbon dioxide outgassing. For SWCGs with very short runs, there can also be undissolved chlorine gas outgassing.
Obviously, no additional products (algaecide, clarifier, shock, etc.) are needed and you've been on this forum long enough to know that we do not change our recommendations for extra products for SWCG pools. It is true that borates can be helpful, but that's true for all pools and is still optional.
As for cell replacement, they used to not last as long, but improvements now even have the manufacturers giving a 3-year warranty and in practice the cells last around 10,000 hours. See the thread
Economics of Saltwater Chlorine Generators where one can see significant savings if one buys a larger unit. Doing so will have the cell last for many years -- not just 5, but 7 or more years.
Chlorine does NOT become significantly less effective at higher pH when CYA is present. While the active chlorine level drops by 50% when the pH goes from 7.5 to 8.0 when there is no CYA in the water, the drop is only 15% when CYA is present. See
this post for technical details. It is true that chlorinating with an SWCG is similar to chlorinating with "liquid chlorine" as they put it, but they are wrong to quote the high pH because they completely ignore the fact that chlorine usage/consumption is acidic so there is effectively no net change in pH. This is described technically in
this post.
Regarding sodium, they go completely over the deep end and not in a good way! Do they even realize that the level of sodium chloride salt in blood plasma and tears is around 8000 ppm (see
this link where for sodium 136–145 mmol/L is 7948-8474 ppm sodium chloride) which is far higher than the 3000 ppm of the pool? Do they realize that sodium skin absorption is minimal? 90% of the sodium we get is from our diet. It's one thing to worry about it in drinking water, but not from absorbing it through the skin.
Dioxin, really? Dioxin is only formed at the high temperatures in incineration stacks and with very high chlorine and organic levels such as found in wood pulp bleaching. Seriously?
Saltwater pools have NOT been banned in Los Angeles County but rather in ONE community named Santa Clarita (see
this link). Also, existing pools ARE grandfathered in. The ban is on new installations or conversions and even then only if discharge of water is into the sewer because they want to limit the amount of chloride going into the Santa Clarita river.
Saltwater chlorine generators do NOT use high voltage. They vary, but are typically in the 18-24 volt range going to the plate stack. The current is somewhat high, but so what?
They are right about oversizing the unit for the best economics, but they are completely wrong with the wattage which is in the 150-220 Watt range, NOT 500-1000. See my linked thread on the economics (again).
They are right about cleaning the cell when needed, but maintaining proper water balance and the use of borates can significantly reduce scale and the required frequency of cleaning thereby further extending cell life.