CSI bug in version 500 (android)

[enabl3d]

I'm a beta tester for the android version of the app, the latest version(500) appears to have a bug with CSI calculation.

If the recorded temperature contains a decimal place CSI shows as "N/A" (only on the CSI page, the main overview page does show the calculated CSI).

I've attached 3 screenshots, with and without decimal place for temperature and the overview page.

Thanks

 

[Leebo]

Well that’s not right! Good catch and welcome to TFP!! Great first post as it’s very helpful.

Let me toss a question as I’m also able to recreate it on iOS, on the “Advice Tab” for CSI, the one shown in the last photo, if you try to enter 77.1°………does it show up as 771, minus the decimal point for you as well?

 

[jesse-99]

Another bug to report, CSI is incorrectly calculated if pH is over 9.0. I noticed that this winter when my pH went up to 9.1.

 

[enabl3d]

Well that’s not right! Good catch and welcome to TFP!! Great first post as it’s very helpful.

Let me toss a question as I’m also able to recreate it on iOS, on the “Advice Tab” for CSI, the one shown in the last photo, if you try to enter 77.1°………does it show up as 771, minus the decimal point for you as well?

Yes. The temp field won't take the decimal point input.

 

[redth]

Yep, both issues seem to be a result of the temperature field not allowing a decimal. That was an oversight on my part. Fixed it here and will be in the next update.

Once the decimal is allowed, the field is correctly pre-populated with the last test result and then the CSI calculation happens correctly.

Appreciate you pointing this one out!

 

[redth]

Another bug to report, CSI is incorrectly calculated if pH is over 9.0. I noticed that this winter when my pH went up to 9.1.

Can you elaborate on this?

I see a slight difference in the rounding, but not enough to be a problem:


On the old calculator page, once you enter 9.1 or higher it just shows "PH Err".
On the app we show -1.00, perhaps that's what you are referring to? We perhaps need to detect when the pH is higher than 9.0 and show a different message?

 

[redth]

Ok I see in the code I already was detecting pH < 6 and > 9 but was treating it as the wrong value result.

I've made some changes which will be in the next version to show a better message instead of "-1.00" in this case: